Skip to content

test(preferences): de-flake PreferencesNavigationTest - #21589

Merged
lukstbit merged 1 commit into
ankidroid:mainfrom
david-allison:21587-flaky-preferences-navigation-test
Aug 24, 2026
Merged

test(preferences): de-flake PreferencesNavigationTest#21589
lukstbit merged 1 commit into
ankidroid:mainfrom
david-allison:21587-flaky-preferences-navigation-test

Conversation

@david-allison

@david-allison david-allison commented Aug 24, 2026

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Purpose / Description

NavigationDrawerActivity.onDrawerClosed has a 100ms delay, now we wait for the activity to launch.

Fixes

How Has This Been Tested?

Test-only

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
test(preferences): de-flake PreferencesNavigationTest
363d52a 
NavigationDrawerActivity.onDrawerClosed has a 100ms delay, now we wait
for the activity to launch.

Fixes 21587

Assisted-by: Claude Fable 5
@david-allison david-allison added the Review High Priority Request for high priority review label Aug 24, 2026
criticalAY
criticalAY approved these changes Aug 24, 2026
View reviewed changes

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!!

@criticalAY criticalAY added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Aug 24, 2026
lukstbit
lukstbit approved these changes Aug 24, 2026
View reviewed changes

@lukstbit lukstbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!
The timeout feels a bit too long at 10 seconds but it's not something to block on.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Aug 24, 2026
@lukstbit
lukstbit added this pull request to the merge queue Aug 24, 2026
Merged via the queue into ankidroid:main with commit 78d3393 Aug 24, 2026
22 of 23 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Aug 24, 2026
@github-actions github-actions Bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@criticalAY criticalAY criticalAY approved these changes
@lukstbit lukstbit lukstbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.25 release

Development

Successfully merging this pull request may close these issues.

Flaky emulator test: testOnCompactMode

3 participants

@david-allison @criticalAY @lukstbit