Skip to content

feat(deckpicker): improve clock error message - #21946

Draft
sanjaysargam wants to merge 1 commit into
ankidroid:mainfrom
sanjaysargam:feat/clock
Draft

sanjaysargam wants to merge 1 commit into
ankidroid:mainfrom
sanjaysargam:feat/clock

Conversation

@sanjaysargam

Copy link
Copy Markdown
Member

Note

Assisted-by: gpt-5.6-terra

Purpose / Description

Device time is shown for the specific clock-sync error, with a shortcut to system Date & Time settings

Fixes

Approach

Show a proper error message with an option to open system Date and Time settings

How Has This Been Tested?

Pixel 10 Pro Fold Emulator
image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions

Copy link
Copy Markdown
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@ZornHadNoChoice

Copy link
Copy Markdown
Collaborator

According to M3 guidelines:

If two actions are provided, one must be a confirming action, and the other a dismissing action.

and

Screenshot_2026-09-21-00-51-09-916_com kiwibrowser browser-edit

So I suggest putting the button on the left above a "Cancel" button.

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a button to go to the system time settings, and a suggested course of action

I don't feel this dialog explains what we expect the user to do when they open the settings.

I also suspect 'Settings' would be a good enough translation, but this is your call

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 20, 2026
@sanjaysargam
sanjaysargam marked this pull request as ready for review September 21, 2026 04:33
@sanjaysargam

Copy link
Copy Markdown
Member Author

@ZornHadNoChoice @david-allison Does it look better now?
image

@ZornHadNoChoice

Copy link
Copy Markdown
Collaborator
  • Following M3 guidelines, the settings button should be to the right of the cancel button. Also, it should be clear so I suggest something more descriptive like "Open settings".
  • The description could be a bit nicer with "Please open the settings [...]" (I don't think "Settings" needs to be capitalized).

@david-allison

david-allison commented Sep 21, 2026

Copy link
Copy Markdown
Member

Order:

  1. Error
  2. Action needed
  3. Debug info

I would be more terse

- Open Settings and correct the date and time, or enable automatic date and time. Then return to AnkiDroid and sync again.
+ Correct the date and time, or enable automatic date and time, then sync again.

@sanjaysargam
sanjaysargam force-pushed the feat/clock branch 2 times, most recently from c229cdc to 439b56c Compare September 21, 2026 10:52
@david-allison

Copy link
Copy Markdown
Member

It would be useful, but not vital to have a screenshot test for this dialog

@david-allison

Copy link
Copy Markdown
Member

CI is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author Strings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve "your clock is not set to the correct time" error

3 participants