feat(deckpicker): improve clock error message - #21946
Draft
sanjaysargam wants to merge 1 commit into
Draft
sanjaysargam wants to merge 1 commit into
sanjaysargam wants to merge 1 commit into
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
sanjaysargam
force-pushed
the
feat/clock
branch
from
September 20, 2026 21:20
975d192 to
05dcf67
Compare
Collaborator
|
According to M3 guidelines:
and
So I suggest putting the button on the left above a "Cancel" button. |
david-allison
requested changes
Sep 20, 2026
david-allison
left a comment
Member
There was a problem hiding this comment.
- Add a button to go to the system time settings, and a suggested course of action
I don't feel this dialog explains what we expect the user to do when they open the settings.
I also suspect 'Settings' would be a good enough translation, but this is your call
sanjaysargam
marked this pull request as ready for review
September 21, 2026 04:33
Member
Author
|
@ZornHadNoChoice @david-allison Does it look better now? |
Collaborator
|
Member
|
Order:
I would be more terse - Open Settings and correct the date and time, or enable automatic date and time. Then return to AnkiDroid and sync again.
+ Correct the date and time, or enable automatic date and time, then sync again. |
sanjaysargam
force-pushed
the
feat/clock
branch
2 times, most recently
from
September 21, 2026 10:52
c229cdc to
439b56c
Compare
Member
|
It would be useful, but not vital to have a screenshot test for this dialog |
Member
|
CI is failing |
sanjaysargam
force-pushed
the
feat/clock
branch
from
September 21, 2026 15:36
439b56c to
907eb0d
Compare
sanjaysargam
marked this pull request as draft
September 21, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Assisted-by: gpt-5.6-terra
Purpose / Description
Device time is shown for the specific clock-sync error, with a shortcut to system Date & Time settings
Fixes
Approach
Show a proper error message with an option to open system Date and Time settings
How Has This Been Tested?
Pixel 10 Pro Fold Emulator

Checklist
Please, go through these checks before submitting the PR.