Skip to content

fix(help): initialize dialog content before restoring child views - #21955

Open
david-allison wants to merge 2 commits into
ankidroid:mainfrom
david-allison:21954
Open

david-allison wants to merge 2 commits into
ankidroid:mainfrom
david-allison:21954

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: GPT-6

Purpose / Description

A HelpPageFragment was restored before onStart() showed the Dialog, causing an IllegalArgumentException.

Fixes

Approach

Call create() earlier

How Has This Been Tested?

Tests added

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

A HelpPageFragment was restored before onStart() showed the Dialog,
causing an IllegalArgumentException.

Part of 21954

Assisted-by: GPT-6
@david-allison david-allison added this to the 2.25 release milestone Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] HelpPageFragment: No view found for com.ichi2.anki:id/fragment_container

1 participant