refactor: added the test for the preprocessing doc#5002
refactor: added the test for the preprocessing doc#5002mayankansys wants to merge 6 commits intomainfrom
Conversation
mayankansys
requested review from
hpohekar,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds a focused regression test to reduce ambiguity around how FluentMode.PRE_POST is interpreted when determining the session class created by the launcher.
Changes:
- Added a new unit test asserting
FluentMode.PRE_POST.get_fluent_value()maps to the same session type asFluentMode.SOLVER.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
documentation
mayankansys
changed the title
mayankansys
changed the title
mayankansys
changed the title
There was a problem hiding this comment.
Pull request overview
Adds a regression test to reduce ambiguity around the PRE/POST Fluent mode mapping, and updates the user-guide text describing pre/post mode behavior.
Changes:
- Add a test asserting
FluentMode.PRE_POSTmaps to the same session type asFluentMode.SOLVER. - Update documentation wording for the “Pre/post mode” section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/test_launcher.py |
Adds a focused regression test for PRE/POST mode mapping. |
doc/source/user_guide/session/launching_ansys_fluent.rst |
Updates the pre/post mode description text in the user guide. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mayankansys
changed the title
| def test_pre_post_mode_maps_to_solver_session_type(): | ||
| assert ( | ||
| FluentMode.PRE_POST.get_fluent_value() is FluentMode.SOLVER.get_fluent_value() | ||
| ) |
There was a problem hiding this comment.
This test only asserts a mapping that's baked into the design: it doesn't verify any behavioural constraint of pre-post mode. We should already have a test covering the actual constraints (no solver execution, etc.) from when the mode was introduced. If this assertion is worth keeping, it fits naturally there rather than as a standalone test.
Co-authored-by: Sean Pearson <93727996+seanpearsonuk@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| Added the test for the preprocessing doc | |||
There was a problem hiding this comment.
PR description says only a single test was added in test_launcher.py, but this PR also changes user guide documentation and adds a changelog fragment. Please update the PR description (or revert unrelated edits) so the stated scope matches the actual changes.
Context
To reduce ambiguity and prevent regressions in the pre/post, a focused test was needed.
Change Summary
Added one test function only in
test_launcher.pyImpact
Affects launcher test coverage in
test_launcher.py