feat(tool runner): add infinite compaction detection #1091
+83
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There's a merge conflict FYI |
| consecutive_compactions += 1 | ||
| log.debug(f"Consecutive compactions: {consecutive_compactions}") | ||
| if consecutive_compactions >= 2: | ||
| raise RuntimeError("Infinite compaction detected: two consecutive iterations performed compaction") |
Collaborator
There was a problem hiding this comment.
nit: we should include something actionable in the error message, what could the user do to prevent this?
Also minor but
Suggested change
| raise RuntimeError("Infinite compaction detected: two consecutive iterations performed compaction") | |
| raise RuntimeError("Potentially infinite compaction detected: two consecutive iterations performed compaction") |
Collaborator
Author
There was a problem hiding this comment.
This happens mostly because the threshold number is very small. If you set it too low, some extra tokens, for example tool definitions won’t be affected by compaction and won’t fit within that threshold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.