Add MSVC support. #146
Open
Add MSVC support. #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC does not support `__attribute__ ((__packed__))`. Add support via `__pragma(pack(push, 1))` when compiling with MSVC.
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
Nov 23, 2023
Needed to get it to work on MSVC
dundargoc
added a commit
to dundargoc/neovim
that referenced
this pull request
Nov 23, 2023
Needed to get it to work on MSVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some poor souls like me need to support cross platform builds.
This patch adds support for MSVC and leaves everything else intact.
MSVC does not support
__attribute__ ((__packed__)).Add support via
__pragma(pack(push, 1))when compiling with MSVC.