fix(windows): Handle HRESULT - #57
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows CopyFile2 error handling in speedcopy by ensuring failed HRESULT return codes are treated as copy failures (raising OSError) rather than being inadvertently treated as success.
Changes:
- Add an
errcheckfunction forCopyFile2to detect failed HRESULTs and raiseOSError. - Add a Windows-only unit test that asserts failed HRESULTs are converted into
OSError. - Update
uv.lockto reflect updated dependency marker/resolution entries.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
speedcopy/win.py |
Adds HRESULT checking via ctypes errcheck for CopyFile2. |
tests/test_speedcopy.py |
Adds a Windows-only regression test for failed HRESULT handling. |
uv.lock |
Updates lockfile dependency markers/entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixed CopyFile2 HRESULT handling. Failed HRESULTs now raise
OSErrorwith the complete HRESULT instead of being silently treated as a successful copy.