Skip to content

feat: Enable limited-duration discount codes for all subscription types #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Enable limited-duration discount codes for all subscription types #1910

wants to merge 2 commits into from
+101 −30

Conversation

@Devwill2
Copy link
Contributor

@Devwill2 Devwill2 commented Nov 5, 2025 •
edited
Loading

Fixes: #1839
Changes:

  • Updated Purchase#set_price_and_rate to check is_recurring_billing? instead of is_tiered_membership?
  • Added is_recurring_billing flag to product serialization for UI
  • Updated discount creation UI to show duration selector for all subscription products
  • Added tests for legacy subscription renewals with limited-duration discounts

Ai Discolsure

None. All code written by me

Livestream Viewing Confirmation

Have watched both the live streams end-to-end

Video

Before:

Screencast.from.2025-11-06.03-08-56.mp4

After:

Screencast.from.2025-11-06.03-11-07.mp4

@Devwill2
Copy link
Contributor Author

Devwill2 commented Nov 9, 2025

@3d-illusions Is this you asking in issue #1839?

@Devwill2 Devwill2 mentioned this pull request Nov 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

offer discounts for subscriptions that are only applied to the innitial purchase, not renewals.

1 participant

@Devwill2