Skip to content

perf(e2e) : Optimize saved-replies test suite #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

perf(e2e) : Optimize saved-replies test suite #1078

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fff2d53
optimized replyHelpers
stefanbinoj Nov 6, 2025
1dffd19
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 6, 2025
01dd7f7
Blank commit --triggering CI
stefanbinoj Nov 6, 2025
0e1a17d
Merge branch 'optimize_reply_helpers' of https://github.com/stefanbin…
stefanbinoj Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 8 additions & 40 deletions tests/e2e/utils/replyHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,50 +50,18 @@ export async function fillSavedReplyForm(page: Page, name: string, content: stri

// Clicks the save button in the create or edit dialog
export async function clickSaveButton(page: Page) {
const addBtn = page.locator('button:has-text("Add")');
const updateBtn = page.locator('button:has-text("Update")');
const saveBtn = page.locator('button:has-text("Save")');
const createDialog = page.locator('[role="dialog"]:has-text("New saved reply")');
const editDialog = page.locator('[role="dialog"]:has-text("Edit saved reply")');

// Map each button to its waitFor promise, returning the button when visible
const buttonPromises = [
updateBtn
.waitFor({ state: "visible", timeout: 5000 })
.then(() => updateBtn)
.catch(() => null),
addBtn
.waitFor({ state: "visible", timeout: 5000 })
.then(() => addBtn)
.catch(() => null),
saveBtn
.waitFor({ state: "visible", timeout: 5000 })
.then(() => saveBtn)
.catch(() => null),
];
const [isCreateContext, isEditContext] = await Promise.all([
createDialog.isVisible({ timeout: 500 }).catch(() => false),
editDialog.isVisible({ timeout: 500 }).catch(() => false),
]);

// Wait for any button to become visible
const buttons = await Promise.all(buttonPromises);
const visibleButton = buttons.find((btn) => btn !== null);

if (visibleButton) {
await visibleButton.click();
} else {
// Fallback logic for context-specific buttons
const isCreateContext = await createDialog.isVisible().catch(() => false);
const isEditContext = await editDialog.isVisible().catch(() => false);

if (isCreateContext) {
const fallbackAddBtn = createDialog.locator('button:has-text("Add")');
await expect(fallbackAddBtn).toBeVisible({ timeout: 5000 });
await fallbackAddBtn.click();
} else if (isEditContext) {
const fallbackUpdateBtn = editDialog.locator('button:has-text("Update")');
await expect(fallbackUpdateBtn).toBeVisible({ timeout: 5000 });
await fallbackUpdateBtn.click();
} else {
throw new Error("No save button found in current context");
}
if (isCreateContext) {
await createDialog.locator('button:has-text("Add")').click();
} else if (isEditContext) {
await editDialog.locator('button:has-text("Update")').click();
}
}

Expand Down