Skip to content

Conversation

@adaelixir
Copy link

#7139

Add trigger option ('plot' | 'columns') to control tooltip activation:

  • 'plot' (default): auto-find nearest element
  • 'columns': only trigger on direct element hover

新增 tooltip 交互触发参数 ('plot' | 'columns') 控制提示框激活方式:

  • 'plot'(默认):自动寻找最近元素
  • 'columns':仅在直接悬停元素时触发

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @adaelixir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the tooltip interaction functionality by introducing a configurable trigger option. This allows users to specify whether tooltips should activate by automatically finding the nearest element on the plot or exclusively when directly hovering over a chart element, providing more granular control over the user experience and interaction design.

Highlights

  • New Tooltip Trigger Parameter: Introduced a new trigger parameter for tooltip interactions, allowing control over activation behavior.
  • Trigger Modes: The trigger parameter supports two modes: 'plot' (default, auto-find nearest element) and 'columns' (only trigger on direct element hover).
  • Core Logic Integration: Integrated the trigger parameter into the core tooltip interaction logic within src/interaction/tooltip.ts to modify how elements are found for tooltip display.
  • Type Definition Update: Updated the TooltipInteraction type definition in src/spec/interaction.ts to include the new trigger property.
  • Test Case Additions: Added test cases in __tests__/plots/ to demonstrate and validate the new 'columns' trigger behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a trigger option for tooltip interactions, allowing control over how tooltips are activated. The new option can be set to 'plot' (the default, which finds the nearest element) or 'columns' (which only triggers on direct element hover). The implementation correctly adds this functionality, primarily affecting bar charts for non-series tooltips. The changes are well-contained and include corresponding updates to type definitions and test cases. My review includes suggestions to improve the documentation for this new feature to ensure its behavior and limitations are clear to developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants