-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: add trigger parameter to tooltip interaction #7170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @adaelixir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the tooltip interaction functionality by introducing a configurable Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a trigger option for tooltip interactions, allowing control over how tooltips are activated. The new option can be set to 'plot' (the default, which finds the nearest element) or 'columns' (which only triggers on direct element hover). The implementation correctly adds this functionality, primarily affecting bar charts for non-series tooltips. The changes are well-contained and include corresponding updates to type definitions and test cases. My review includes suggestions to improve the documentation for this new feature to ensure its behavior and limitations are clear to developers.
#7139
Add trigger option ('plot' | 'columns') to control tooltip activation:
新增 tooltip 交互触发参数 ('plot' | 'columns') 控制提示框激活方式: