Replaces in memory bulk status with retrieval#6149
Open
keith-turner wants to merge 1 commit intoapache:mainfrom
Open
Replaces in memory bulk status with retrieval#6149keith-turner wants to merge 1 commit intoapache:mainfrom
keith-turner wants to merge 1 commit intoapache:mainfrom
Conversation
The manager tracked the status of bulk imports in memory. This tracking would be lost when the manager restarted. Replaced this tracking with new code that retrieves the current status from persisted data. All the in memory tracking code was deleted. Deleted a shell command that relied on the old way of doing things and added a new admin command. This was done because the new way needs a server context which is not available in the shell. Updated the monitor to call the new code. The new code offers more information. Will open a follow on issue to display this additional information on the monitor. These changes were made in support of apache#6139. Anything the manager tracks in memory makes it harder to split the manager into multiple processes.
dlmarion
approved these changes
Feb 24, 2026
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
This looks good. The Monitor changes here , in the rest package, will keep the monitor working for now. Ultimately, the plan was to remove the rest package as the Monitor is ported over to use the endpoints in the next package which is driven off the metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager tracked the status of bulk imports in memory. This tracking would be lost when the manager restarted. Replaced this tracking with new code that retrieves the current status from persisted data. All the in memory tracking code was deleted.
Deleted a shell command that relied on the old way of doing things and added a new admin command. This was done because the new way needs a server context which is not available in the shell.
Updated the monitor to call the new code. The new code offers more information. Will open a follow on issue to display this additional information on the monitor.
These changes were made in support of #6139. Anything the manager tracks in memory makes it harder to split the manager into multiple processes.