fix: accept complete HTTP responses for full ranges - #858
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
RanaPriyansh
force-pushed
the
fix/http-full-range-806
branch
from
September 24, 2026 09:45
bc05cd9 to
7e9ccf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #806. Related to #846.
Rationale for this change
The HTTP client rejects complete HTTP 200 responses when a requested range covers the entire object.
What changes are included in this PR?
Accept HTTP 200 when the complete response satisfies the requested range. Ignore Content-Range on these responses. Preserve HTTP 206 validation and reject complete responses for requests that cover only part of the object.
For body retries, require the response size to match the exact remaining range. Preserve ETag checks.
Tests cover bounded, offset and suffix ranges, empty objects, misleading headers, rejection cases, and body retries.
On Rust 1.97.0, the two HTTP regressions fail on the unchanged baseline. The candidate passes 11 public range tests, 7 shared HTTP tests, and the HTTP library suite (137 passed, 1 ignored). Formatting and strict all-feature/all-target Clippy pass. External cloud integration tests were not run.
AI assistance through OpenAI Codex produced the implementation, tests, and draft text.
Are there any user-facing changes?
Range requests that cover the entire object can accept HTTP 200 responses. No public API signatures change.