fix: honor GCS skip_signature during uploads - #861
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #520.
Rationale for this change
GCS upload requests fetched credentials and added a Bearer header even when
with_skip_signature(true)was set.Request::sendbypassed the existing skip-aware credential helper.What changes are included in this PR?
Route upload requests through
GoogleCloudStorageConfig::get_credential()and the optional Bearer-auth helper. Add a mock-server regression that checks credential calls and Authorization headers with signing enabled and disabled.Are there any user-facing changes?
GCS uploads with
skip_signature=trueno longer fetch credentials at request time or send an Authorization header. The public API is unchanged.Validation:
cargo test --features=aws,azure,gcp,httppassed: 264 unit tests, 3 integration tests, 1 HTTP test, and 57 doctests. Six unit tests and two doctests were ignored.--features gcpand--no-default-features --features gcp-base. Formatting and diff checks passed.cargo test --features gcphad one unrelated doctest failure: a doctest imports Azure when the Azure feature is disabled. The doctest passed with the repository CI feature set above.Live GCS and custom-connector behavior were not tested. Builder-time credential-file parsing is unchanged.
Codex used.