feat: add BucketStore trait for bucket create, delete and exists - #868
Open
Aditya1404Sal wants to merge 2 commits into
Open
Aditya1404Sal wants to merge 2 commits into
Aditya1404Sal wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #865.
Rationale for this change
See #865 please
What changes are included in this PR?
object_store::bucket::BucketStoretrait withcreate_bucket,delete_bucketandbucket_exists, implemented for AmazonS3, GoogleCloudStorage and MicrosoftAzure.GoogleCloudStorageBuilder::with_project_idandGoogleConfigKey::ProjectId(
GOOGLE_PROJECT_ID), needed to create GCS buckets.(LocalStack, fake-gcs-server and Azurite).
I'm happy to split this per provider if that's easier to review.
Are there any user-facing changes?
Yes, additive only: the new trait and the gcs project-id option. There are no breaking changes.