GH-47720: [C++][FlightRPC] ODBC Columns Metadata #48049
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: alinalibq <[email protected]>
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
commented
Nov 4, 2025
Comment on lines
+46
to
+82
| // Helper functions | ||
| void CheckSQLColumns( | ||
| SQLHSTMT stmt, const std::wstring& expected_table, | ||
| const std::wstring& expected_column, const SQLINTEGER& expected_data_type, | ||
| const std::wstring& expected_type_name, const SQLINTEGER& expected_column_size, | ||
| const SQLINTEGER& expected_buffer_length, const SQLSMALLINT& expected_decimal_digits, | ||
| const SQLSMALLINT& expected_num_prec_radix, const SQLSMALLINT& expected_nullable, | ||
| const SQLSMALLINT& expected_sql_data_type, const SQLSMALLINT& expected_date_time_sub, | ||
| const SQLINTEGER& expected_octet_char_length, | ||
| const SQLINTEGER& expected_ordinal_position, | ||
| const std::wstring& expected_is_nullable) { | ||
| CheckStringColumnW(stmt, 3, expected_table); // table name | ||
| CheckStringColumnW(stmt, 4, expected_column); // column name | ||
|
|
||
| CheckIntColumn(stmt, 5, expected_data_type); // data type | ||
|
|
||
| CheckStringColumnW(stmt, 6, expected_type_name); // type name | ||
|
|
||
| CheckIntColumn(stmt, 7, expected_column_size); // column size | ||
| CheckIntColumn(stmt, 8, expected_buffer_length); // buffer length | ||
|
|
||
| CheckSmallIntColumn(stmt, 9, expected_decimal_digits); // decimal digits | ||
| CheckSmallIntColumn(stmt, 10, expected_num_prec_radix); // num prec radix | ||
| CheckSmallIntColumn(stmt, 11, | ||
| expected_nullable); // nullable | ||
|
|
||
| CheckNullColumnW(stmt, 12); // remarks | ||
| CheckNullColumnW(stmt, 13); // column def | ||
|
|
||
| CheckSmallIntColumn(stmt, 14, expected_sql_data_type); // sql data type | ||
| CheckSmallIntColumn(stmt, 15, expected_date_time_sub); // sql date type sub | ||
| CheckIntColumn(stmt, 16, expected_octet_char_length); // char octet length | ||
| CheckIntColumn(stmt, 17, | ||
| expected_ordinal_position); // oridinal position | ||
|
|
||
| CheckStringColumnW(stmt, 18, expected_is_nullable); // is nullable | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Hi @lidavidm do you have any feedback on this type of helper functions CheckSQLColumns that check results from multiple columns? This type is different from the getter functions like ValidateGreaterThan(...)
Member
There was a problem hiding this comment.
I suppose this is fine given the structure of the test
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Nov 6, 2025
github-actions
bot
added
awaiting merge
alinaliBQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add support for returning columns metadata from the connected data source.
What changes are included in this PR?
Are these changes tested?
Tested in local MSVC
Are there any user-facing changes?
N/A