GH-47707: [C++][FlightRPC] Add tests for descriptor handle allocation #48053
+270
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
commented
Nov 10, 2025
| // GH-47706 TODO: Add tests for SQLAllocStmt, pre-requisite requires | ||
| // SQLDriverConnect implementation | ||
|
|
||
| // GH-47707 TODO: Add tests for SQL_HANDLE_DESC implementation for |
Contributor
Author
There was a problem hiding this comment.
TODO - add /brief doxygen doc for RevertAppDescriptor in odbc_statement.h
github-actions
bot
added
awaiting committer review
Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
commented
Nov 11, 2025
Contributor
Author
There was a problem hiding this comment.
This PR needs to be rebased onto main after PR #47764 is merged
alinaliBQ
force-pushed
the
gh-47707-descriptor-handle
branch
from
65a1708 to
5041f73
Compare
alinaliBQ
changed the title
alinaliBQ
commented
Nov 11, 2025
Contributor
Author
There was a problem hiding this comment.
Similar here, would need to rebase after #47762 merged to get rid of duplicate changes, as this PR depends on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add tests for
SQL_HANDLE_DESCdescriptor handle allocation, and diagnostics testWhat changes are included in this PR?
SQL_HANDLE_DESCAre these changes tested?
Tested on local MSVC Windows
Are there any user-facing changes?
N/A