GH-48019 : [C++][FlightRPC] work-in-progress Enable ODBC in MSVC CI #48067
+128
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having static vs. shared issue
To make it easier to manage dependencies
|
|
alinaliBQ
changed the title
Contributor
Author
|
Please note that I created this WIP PR to test the CI since Arrow's repo allows for longer runs |
windows-mingw also has timeout of 2hr
* reason: gtest can't be used with C++17. Arrow project doesn't support C++ 17 yet.
* Add back `CMAKE_CXX_STANDARD: "17"`
Borrowed from the Glib workflow
`ARROW_BOOST_USE_SHARED` is restored to `OFF`, which according to Windows doc should help with the debug build now. Retore value of `ARROW_BUILD_BENCHMARKS`, though noting it is set to `OFF` in GLib MSVC workflow.
alinaliBQ
force-pushed
the
gh-48019-build-odbc-msvc
branch
from
354f731 to
7349d67
Compare
Getting ``` orc.lib(Exceptions.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in unity_2_cxx.cxx.obj orc.lib(Exceptions.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in unity_2_cxx.cxx.obj ``` when building with debug and presumably ARROW_ORC
Since we have a release build, can enable boost as shared. With `ARROW_BOOST_USE_SHARED = OFF`, I am getting error ``` D:\a\arrow\arrow\build\cpp\vcpkg_installed\x64-windows\include\boost/filesystem/config.hpp(96): fatal error C1189: #error: Must not define both BOOST_FILESYSTEM_DYN_LINK and BOOST_FILESYSTEM_STATIC_LINK ``` Also increased time limit, since 2 hours don't seem to be enough to finish the vcpkg build
Since we need to use link to boost dynamically, we need to remove the bundled boost library flag. Add debug messages.
Addresses comment apache#40939 (comment) Replace boost::optional with std::optional in ODBC codebase apache#48084
Attempt to include Arrow headers before ODBC headers to avoid conflict with arrow/flight/sql/types.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Enable ODBC in MSVC CI and disable ODBC in MinGW CI since MSVC is the main platform for ODBC.
What changes are included in this PR?
.github/workflows/cpp_windows.ymlboost-optionalas it blocks ODBC from building in MSVCAre these changes tested?
Tested in CI
Are there any user-facing changes?
N/A
SparseUnionTypedestructor when arrow.dll is unloaded via ODBC driver manager #48019