GH-48560: [C++][Parquet] When fuzzing, treat Table validation error as hard error #48863
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
…rror as hard error
pitrou
force-pushed
the
gh48560-fuzz-table-validation
branch
from
7854761 to
1f1d34a
Compare
Member
Author
|
@github-actions crossbow submit fuzz |
|
Revision: 1f1d34a Submitted crossbow builds: ursacomputing/crossbow @ actions-ccbec654ec
|
wgtmac
approved these changes
Jan 16, 2026
github-actions
bot
added
awaiting committer review
adamreeve
approved these changes
Jan 18, 2026
Member
Author
|
Thanks for the reviews. I've merged this, let's "brace for impact" as the saying goes. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 34045db. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently, when fuzzing a Parquet file, proper errors are ignored since the file is most of the time simply invalid: it's ok to get an error.
However, if reading a Parquet row group was successful, the Parquet reader should have ensured that the resulting Table is structurally sound: calling
Table::Validateshould succeed, and if it fails then it should report a bug.What changes are included in this PR?
Call
Table::Validateon a successful read from the Parquet fuzz target, and abort if validation fails.Table::ValidateFull, however, is allowed to fail, as for example a Parquet UTF8 column could contain invalid UTF8 bytes, and we don't detect that when decoding.Are these changes tested?
By existing tests and fuzz regression files.
Actual running this on OSS-Fuzz will tell us if this is really a good idea.
Are there any user-facing changes?
No.