_yaml: fix confusing error message #2089
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the ruamel-yaml CParser import instantiation outside of try-catch. The catch reports 'Severely malformed YAML', which isn't the case if you you cant't import CParser
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
gtristan
reviewed
Nov 10, 2025
| cpdef MappingNode load_data(str data, int file_index=node._SYNTHETIC_FILE_INDEX, str file_name=None, bint copy_tree=False): | ||
| cdef Representer rep | ||
|
|
||
| try: |
Contributor
There was a problem hiding this comment.
Ideally, we would have the precise exception below instead of the blind except Exception statement.
Given that determining what exception specifically is raised there may be quite difficult, I think I'd still be more comfortable with an additional except ImportError block, so that anything else happening inside the yaml.CParser(data) constructor is still in the try block.
E.g. just adding the following before the blind except may be preferrable:
try:
...
except ImportError as e:
raise e
except Exception:
... keeping the same blind except...
``
Contributor
|
Link to relevant issue: #1833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ruamel-yaml CParser import instantiation outside of try-catch. The catch reports 'Severely malformed YAML', which isn't the case if you you cant't import CParser