[backport camel-4.18.x] CAMEL-24203: camel-aws-security-hub - implement the declared getFindingAggregator operation#24973
Merged
Conversation
…ngAggregator operation (apache#24940) Implements the operation and adds the finding-aggregator ARN header. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
gnodet
approved these changes
Jul 21, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Backport review: CAMEL-24203 — implement getFindingAggregator operation (4.18.x)
Clean backport of #24940. Changes are well-structured and consistent with the existing codebase:
SecurityHubConstants: NewFINDING_AGGREGATOR_ARNheader constant with proper@Metadataannotation — follows the pattern ofFINDING_ID,PRODUCT_ARN, etc.SecurityHubProducer: Adds thegetFindingAggregatorcase to the operation switch and implements it via theexecuteOperationhelper — same pattern asgetFindingHistory,describeHub, etc. Validates the required ARN header.- Test: Mock-based unit test verifies the operation is correctly routed (no longer falls through to "Unsupported operation") and the ARN header is properly extracted and passed to the SDK request.
- Generated files: Catalog JSON and EndpointDSL factory regenerated and included.
✅ No issues found.
Reviewed with Claude Code on behalf of gnodet. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
davsclaus
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24940 to
camel-4.18.x. Fixes CAMEL-24203 on the 4.18.x line.getFindingAggregatorwas declared inSecurityHubOperationsbut had no case in the producer switch, so selecting it always failed with "Unsupported operation". It is now implemented via the module'sexecuteOperationhelper, with theCamelAwsSecurityHubFindingAggregatorArnheader it requires. Regenerated metadata included; the test is adapted to junit5 on this branch.Not applicable to
camel-4.14.x— the camel-aws-security-hub component does not exist on that branch.Claude Code on behalf of oscerd