UI: Update domain level configuration #11571

Pearl1594 · 2025-09-03T18:36:46Z

Description

This PR fixes #11570
Following issues were fixed:

When updating domain-level setting (from UI) it is observed that it doesn't pass the domain id, hence leading to the update of the global setting
On switching between different domains, the settings weren't getting updated. i.e., while the API returns the correct value, the settings displayed the older domains values.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-09-03T18:42:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.58%. Comparing base (3d6ec29) to head (c576d32).
⚠️ Report is 195 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #11571      +/-   ##
============================================
+ Coverage     17.36%   18.58%   +1.22%     
- Complexity    15237    16538    +1301     
============================================
  Files          5888     5911      +23     
  Lines        525741   567407   +41666     
  Branches      64164    81153   +16989     
============================================
+ Hits          91274   105454   +14180     
- Misses       424167   450696   +26529     
- Partials      10300    11257     +957

Flag	Coverage Δ
uitests	`3.85% <ø> (+0.22%)`	⬆️
unittests	`19.68% <ø> (+1.28%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-09-03T19:36:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

shwstppr · 2025-09-04T03:46:01Z

@blueorangutan ui

blueorangutan · 2025-09-04T03:47:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-09-04T04:04:56Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11571 (QA-JID-737)

harikrishna-patnala

@Pearl1594 does this need change in base branch to 4.20 ?

ui/src/views/setting/ConfigurationValue.vue

weizhouapache · 2025-09-15T07:23:17Z

I could not reproduce the issue with updateconfiguration in 4.20, the domainid is passed

cloudstack/ui/src/components/view/SettingsTab.vue

Lines 172 to 175 in 2cd7d8a

    
                 api('updateConfiguration', { 
        
                   [this.scopeKey]: this.resource.id, 
        
                   name: item.name, 
        
                   value: this.editableValue

it seems to be a regression of #10596

moving to 4.22 milestone. cc @Pearl1594 @harikrishna-patnala

Copilot

Pull Request Overview

This PR fixes domain-level configuration updates in the UI by ensuring domain ID is passed when updating domain settings and by refreshing configuration data when switching between domains.

Added resource prop passing to maintain domain context across configuration components
Fixed domain ID parameter passing in updateConfiguration API calls
Added watchers to refresh configuration data when loading state changes or config records update

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ui/src/views/setting/ConfigurationValue.vue	Added resource prop, watchers for data refresh, and domain ID parameter handling
ui/src/views/setting/ConfigurationTable.vue	Added resource prop and passed it to ConfigurationValue component
ui/src/components/view/SettingsTab.vue	Passed resource prop to ConfigurationTable component

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

ui/src/views/setting/ConfigurationValue.vue

kiranchavala · 2025-11-06T09:57:43Z

@blueorangutan package

blueorangutan · 2025-11-06T10:00:03Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-06T12:25:10Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15652

DaanHoogland

clgtm and tested in lab, but reset does not work for domein-settings.

DaanHoogland · 2025-11-06T16:39:37Z

@blueorangutan package

blueorangutan · 2025-11-06T16:42:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-06T17:47:52Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15665

blueorangutan · 2025-11-07T15:29:46Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15681

DaanHoogland

white box tested in a lab, checking the values for multiple domains and globally for a setting in both the DB and the UI

nvazquez

Code LGTM

DaanHoogland · 2025-11-07T16:36:07Z

@blueorangutan package

blueorangutan · 2025-11-07T16:38:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-11-07T17:58:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15682

DaanHoogland · 2025-11-10T08:00:49Z

@blueorangutan test

blueorangutan · 2025-11-10T08:02:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sonarqubecloud · 2025-11-10T10:39:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

blueorangutan · 2025-11-10T22:29:57Z

[SF] Trillian test result (tid-14793)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49316 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11571-t14793-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

UI: Update domain level configuration

2ab54d9

Pearl1594 requested review from DaanHoogland, harikrishna-patnala, kiranchavala and weizhouapache September 3, 2025 18:36

boring-cyborg bot added the component:UI label Sep 3, 2025

weizhouapache added this to the 4.20.2 milestone Sep 3, 2025

harikrishna-patnala reviewed Sep 4, 2025

View reviewed changes

shwstppr reviewed Sep 4, 2025

View reviewed changes

ui/src/views/setting/ConfigurationValue.vue Show resolved Hide resolved

ui/src/views/setting/ConfigurationValue.vue Outdated Show resolved Hide resolved

bernardodemarco self-requested a review September 4, 2025 11:39

weizhouapache self-assigned this Sep 10, 2025

weizhouapache modified the milestones: 4.20.2, 4.22.0 Sep 15, 2025

vishesh92 requested a review from Copilot October 10, 2025 07:55

Copilot AI reviewed Oct 10, 2025

View reviewed changes

ui/src/views/setting/ConfigurationValue.vue Show resolved Hide resolved

remove loading, as it's not being passed by the parent component

0cd7af6

Pearl1594 requested review from harikrishna-patnala and shwstppr October 10, 2025 14:46

DaanHoogland linked an issue Nov 6, 2025 that may be closed by this pull request

UI /API : Domain level ldap settings are not peristed #11499

Closed

weizhouapache removed their assignment Nov 6, 2025

DaanHoogland approved these changes Nov 6, 2025

View reviewed changes

reset only domain level setting to global level value

c576d32

DaanHoogland closed this Nov 7, 2025

DaanHoogland reopened this Nov 7, 2025

DaanHoogland approved these changes Nov 7, 2025

View reviewed changes

nvazquez approved these changes Nov 7, 2025

View reviewed changes

DaanHoogland changed the base branch from main to 4.22 November 7, 2025 16:34

DaanHoogland closed this Nov 10, 2025

DaanHoogland reopened this Nov 10, 2025

DaanHoogland modified the milestones: 4.22.0, 4.22.1 Nov 11, 2025

DaanHoogland merged commit 15439ed into 4.22 Nov 11, 2025
81 of 99 checks passed

DaanHoogland deleted the fix-domain-scope-config branch November 11, 2025 08:30

This was referenced Nov 11, 2025

UI /API : Domain level ldap settings are not peristed #11499

Closed

Domain Settings page not reloaded #12044

Closed

UI: Update domain level configuration #11571

UI: Update domain level configuration #11571

Conversation

Pearl1594 commented Sep 3, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Sep 3, 2025

Quality Gate passed

Uh oh!

shwstppr commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

blueorangutan commented Sep 4, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

weizhouapache commented Sep 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

kiranchavala commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

blueorangutan commented Nov 7, 2025

Uh oh!

DaanHoogland commented Nov 10, 2025

Uh oh!

blueorangutan commented Nov 10, 2025

Uh oh!

sonarqubecloud bot commented Nov 10, 2025

Quality Gate passed

Uh oh!

blueorangutan commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

codecov bot commented Sep 3, 2025 •

edited

Loading