fix Host Password Exposed in Command-Line Logging #12010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanHoogland
reviewed
Nov 7, 2025
| Pair<Boolean, String> result; | ||
| try { | ||
| logger.debug("Executing command in Host: " + cmdLine); | ||
| logger.debug("Executing password update command on host: " + hostIp + " for user: " + username); |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.debug("Executing password update command on host: " + hostIp + " for user: " + username); | |
| logger.debug("Executing password update command on host: {} for user: {}”, hostIp, username); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12010 +/- ##
=========================================
Coverage 17.56% 17.56%
- Complexity 15540 15544 +4
=========================================
Files 5909 5909
Lines 529059 529059
Branches 64617 64617
=========================================
+ Hits 92919 92940 +21
+ Misses 425687 425664 -23
- Partials 10453 10455 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Host Password Exposed in Command-Line Logging During Password Update Operations. #11989