-
Notifications
You must be signed in to change notification settings - Fork 1.2k
import network acl rules using csv #12013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12013 +/- ##
============================================
- Coverage 17.56% 17.55% -0.02%
+ Complexity 15545 15538 -7
============================================
Files 5909 5911 +2
Lines 529056 529291 +235
Branches 64617 64656 +39
============================================
- Hits 92947 92900 -47
- Misses 425654 425937 +283
+ Partials 10455 10454 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm so far, let me test when you are ready @sudo87
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15706 |
Description
This PR fixes #8858
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Test file:
AclRules-test-acls-e27d1e32-09b6-4cb9-acde-2a748d857678.csv
How did you try to break this feature and the system with this change?