Skip to content

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Nov 7, 2025

Description

This PR fixes #8858

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2025-11-10 at 5 10 23 PM
Screenshot 2025-11-10 at 5 10 31 PM
Screenshot 2025-11-10 at 5 10 40 PM

How Has This Been Tested?

Test file:
AclRules-test-acls-e27d1e32-09b6-4cb9-acde-2a748d857678.csv

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 0% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.55%. Comparing base (d160731) to head (63cde64).
⚠️ Report is 12 commits behind head on 4.22.

Files with missing lines Patch % Lines
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java 0.00% 69 Missing ⚠️
.../api/command/user/network/ImportNetworkACLCmd.java 0.00% 38 Missing ⚠️
.../api/command/user/network/CreateNetworkACLCmd.java 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12013      +/-   ##
============================================
- Coverage     17.56%   17.55%   -0.02%     
+ Complexity    15545    15538       -7     
============================================
  Files          5909     5911       +2     
  Lines        529056   529291     +235     
  Branches      64617    64656      +39     
============================================
- Hits          92947    92900      -47     
- Misses       425654   425937     +283     
+ Partials      10455    10454       -1     
Flag Coverage Δ
uitests 3.57% <ø> (-0.02%) ⬇️
unittests 18.62% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo87
Copy link
Collaborator Author

sudo87 commented Nov 10, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm so far, let me test when you are ready @sudo87

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants