-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix API Request Parameters Logged Credential Masking in ApiServer #12017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix API Request Parameters Logged Credential Masking in ApiServer #12017
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12017 +/- ##
============================================
- Coverage 16.18% 16.18% -0.01%
Complexity 13305 13305
============================================
Files 5657 5657
Lines 498466 498478 +12
Branches 60491 60493 +2
============================================
- Hits 80696 80693 -3
- Misses 408789 408804 +15
Partials 8981 8981
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15680 |
|
@YLChen-007 , is this the same as #12020 ? should we close one of the two? |
oh Yes, we should close one of them. |
thanks, closing this one |
Thiis PR fixed API Request Parameters Logged Credential Masking in ApiServer. #12009