Skip to content

Conversation

@YLChen-007
Copy link

Thiis PR fixed API Request Parameters Logged Credential Masking in ApiServer. #12009

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.18%. Comparing base (e90e436) to head (dd55369).
⚠️ Report is 5 commits behind head on 4.20.

Files with missing lines Patch % Lines
server/src/main/java/com/cloud/api/ApiServer.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12017      +/-   ##
============================================
- Coverage     16.18%   16.18%   -0.01%     
  Complexity    13305    13305              
============================================
  Files          5657     5657              
  Lines        498466   498478      +12     
  Branches      60491    60493       +2     
============================================
- Hits          80696    80693       -3     
- Misses       408789   408804      +15     
  Partials       8981     8981              
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Nov 7, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15680

@DaanHoogland
Copy link
Contributor

@YLChen-007 , is this the same as #12020 ? should we close one of the two?

@YLChen-007
Copy link
Author

@YLChen-007 , is this the same as #12020 ? should we close one of the two?

oh Yes, we should close one of them.

@DaanHoogland
Copy link
Contributor

@YLChen-007 , is this the same as #12020 ? should we close one of the two?

oh Yes, we should close one of them.

thanks, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants