Experiments

[garydgregory]

No description provided.

In general, to avoid implicit narrowing in compound assignments, ensure that both sides of the assignment have compatible, non-narrowing types. Either widen the destination variable’s type or explicitly perform a checked conversion that preserves semantics and handles out-of-range values safely.

Here, the simplest fix that preserves existing behavior is to keep charsRead as an int (to avoid changing the class’s public/observable types) and change the compound assignment to an explicit, range-checked update. We can compute the amount to add as an int, clamped to the remaining allowable range before overflow, and then update charsRead. Since the logic of this class already limits reading based on maxCharsFromTargetReader (also an int), bounding the increment is consistent with its purpose. Specifically, in skip(long n), instead of charsRead += n, we compute an int delta as n > Integer.MAX_VALUE ? Integer.MAX_VALUE : (int) n, then clamp that delta so charsRead + delta does not exceed Integer.MAX_VALUE, and finally do charsRead += delta. This removes the implicit narrowing and makes the cast explicit and controlled. All changes are confined to the skip method in src/main/java/org/apache/commons/io/input/BoundedReader.java; no new imports or other methods are needed.