-
Notifications
You must be signed in to change notification settings - Fork 996
Review create default values and small rework
#1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
=========================================
Coverage ? 74.88%
=========================================
Files ? 13
Lines ? 1724
Branches ? 0
=========================================
Hits ? 1291
Misses ? 433
Partials ? 0
Continue to review full report at Codecov.
|
6663d7b to
5651b57
Compare
5651b57 to
88d3d00
Compare
|
Sorry this took a bit longer to review and merge — I'd like to move things forward and get this PR ready. How would you prefer to proceed?
Here are the changes I'd recommend:
Even though this is just a template (and we expect developers to set their own package ID), this one feels more accurate to the Apache Cordova project. While there is a Regarding the For references, I also submitted related PRs to |
|
@erisu If you're okay with it, I'll let you create the new PR instead. |
Platforms affected
iOS
Motivation and Context
Mixed default values for
createbetween cli doc, cordova-android and cordova-ios.Description
Package ids were mostly correct but not all, and same for project name. Suggested proper defaults:
io.cordova.helloCordovaHello CordovaSee linked PRs: apache/cordova-cli#554, apache/cordova-android#1213
And
createProjecton how to init and deal with its parametersremove useless check on project_parent asfs.ensureDirSyncis used(see each commit for detail on my steps)
Testing
npm testsuccessChecklist
(platform)if this change only applies to one platform (e.g.(android))