[branch-51] bugfix: select_columns should validate column names #18624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dqkqd would you mind reviewing? (Same as the other PR but targeting our release branch) |
37 tasks
… which would error on duplicates
timsaucer
changed the title
timsaucer
changed the title
alamb
reviewed
Nov 11, 2025
| if fields.is_empty() { | ||
| Err(unqualified_field_not_found(name, self.plan.schema())) | ||
| } else { | ||
| Ok(fields) |
Contributor
There was a problem hiding this comment.
do we also have to check that we found all the fields?
Like what if some fields are found and some are not 🤔
Member
Author
There was a problem hiding this comment.
I do think this check will ensure we have all the fields. In fact, the unit test I added has 1 field that does exist and 2 that do not.
The if a single one of the requested columns returns no fields, then the entire operation should fail. Is there a different case you're thinking of?
Contributor
There was a problem hiding this comment.
Nope -- this looks good to me
alamb
approved these changes
Nov 12, 2025
alamb
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #18623 but targeting branch51
See that PR for details.