chore: Enforce lint rule clippy::needless_pass_by_value to datafusion-catalog
#18638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-catalog Signed-off-by: Alan Tang <[email protected]>
Standing-Man
changed the title
clippy::needless_pass_by_value to datafusion-catalog
alamb
approved these changes
Nov 12, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @Standing-Man
Jefffrey
approved these changes
Nov 13, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
clippy::needless_pass_by_valuetodatafusion-catalog#18609.Rationale for this change
The type
impl AsRef<str>is implicitlySized, meaning its size is known at compile time.&(impl AsRef<str>)is a reference to a concrete type that implementsAsRef<str>and isSized. However, thisSizedbound prevents passing references to dynamically sized types such as&str,String, orBox<dyn Trait>.Therefore, we add
+ ?Sizedto indicate that the referenced type might not have a fixed size — that is, it allows the referenced type to be dynamically sized.What changes are included in this PR?
clippy::needless_pass_by_valuetodatafusion-catalog.Are these changes tested?
Are there any user-facing changes?