Skip to content

test: move limit fuzz tests to the FuzzTest driver - #27325

Merged
2010YOUY01 merged 4 commits into
apache:mainfrom
Nagato-Yuzuru:fuzz-migrate-limit
Nov 20, 2026
Merged

2010YOUY01 merged 4 commits into
apache:mainfrom
Nagato-Yuzuru:fuzz-migrate-limit

Conversation

@Nagato-Yuzuru

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

The TopK fuzz tests use an unseeded RNG and cannot reproduc failure. Moves them to the shared FuzzTest driver.

What changes are included in this PR?

  • Move core/tests/fuzz_cases/limit_fuzz.rs to fuzz/tests/suites/limit.rs.
  • Case seed k selects the input size SIZES[k % 4] and the data seed k / 4. Each run has 4 cases, one for each size, as before.
  • The data and the random limit come from the case seed. The run seed is random, so each run still uses new data, and the driver prints the seed on failure.
  • LimitFuzzer and the FUZZERS table register the 4 suites. The suite names are the old test names.

What is the testing strategy for this PR?

I changed the TopK heap condition locally. test_sort_topk_i32 failed with TopK mismatch and printed the case seed.

Are there any user-facing changes?

No

@github-actions github-actions Bot added the core Core DataFusion crate label Nov 11, 2026

@2010YOUY01 2010YOUY01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Before merging, we should split the tests, so they can run on multiple threads.

Clean-up advices are optional.

Comment thread datafusion/fuzz/tests/fuzz.rs Resolved
Comment thread datafusion/fuzz/tests/suites/limit.rs Resolved
Comment thread datafusion/fuzz/tests/suites/limit.rs Resolved
Comment thread datafusion/fuzz/tests/suites/limit.rs Resolved
@Nagato-Yuzuru

Copy link
Copy Markdown
Contributor Author

Thanks, updated. I also fixed a typo in the input sizes: 1_0000 → 1_000.

@2010YOUY01 2010YOUY01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@2010YOUY01
2010YOUY01 added this pull request to the merge queue Nov 20, 2026
Merged via the queue into apache:main with commit a56c519 Nov 20, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate v57.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants