Skip to content

Conversation

@ChaoquanTao
Copy link
Contributor

@ChaoquanTao ChaoquanTao commented Feb 25, 2025

Purpose of the pull request

This PR optimizes the getLog method to avoid infinite recursive invoke in front end

close #17025

Brief change log

  • Add getLog method in batch-task.tsx, stream-task.tsx and dag/index.tsx

Verify this pull request

This pull request is code cleanup without any test coverage.

@github-actions github-actions bot added the UI ui and front end related label Feb 25, 2025
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Feb 26, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Feb 26, 2025
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@SbloodyS SbloodyS modified the milestones: 3.3.0-alpha, 3.3.1 Mar 30, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@ruanwenjun
Copy link
Member

I am not sure if this PR can solve this problem, the main reason is the front-end doesn't know whether it should stop fetch log, since it doesn't know if the log had come to the end, the response doesn't tell the front-end where there exist more log.

@Data
@AllArgsConstructor
public class ResponseTaskLog {

    private int lineNum;
    private String message;
}

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Aug 16, 2025
@SbloodyS SbloodyS removed this from the 3.3.1 milestone Aug 18, 2025
@github-actions github-actions bot removed the Stale label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement make more easy to user or prompt friendly UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Infinite recursive queryLog request and unreasonable limit param cause both frontend and backend oom

4 participants