Skip to content

[Improvement-17658][API] parameter placeholder not replaced #17659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[Improvement-17658][API] parameter placeholder not replaced #17659

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f014b5
fix parameter placeholder not replaced
leehaut Nov 8, 2025
8c8f5f5
fix parameter placeholder not replaced
leehaut Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ public enum Status {

TASK_PARALLELISM_PARAMS_ERROR(50080, "task parallelism parameter is not valid", "任务并行度参数无效"),
TASK_COMPLEMENT_DATA_DATE_ERROR(50081, "The range of date for complementing date is not valid", "补数选择的日期范围无效"),
WORKFLOW_DEFINE_ILLEGAL_ARG(50082, "create workflow definition illegal {0}", "创建工作流非法 {0}"),

HDFS_NOT_STARTUP(60001, "hdfs not startup", "hdfs未启用"),
STORAGE_NOT_STARTUP(60002, "storage not startup", "存储未启用"),
Expand Down
5 changes: 4 additions & 1 deletion ...main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,9 +485,12 @@ private List<TaskDefinitionLog> generateTaskDefinitionList(String taskDefinition
return taskDefinitionLogs;
} catch (ServiceException ex) {
throw ex;
} catch (IllegalArgumentException ex) {
log.error("Generate task definition list failed, meet an illegal exception", ex);
throw new ServiceException(Status.WORKFLOW_DEFINE_ILLEGAL_ARG, ex.getMessage());
} catch (Exception e) {
log.error("Generate task definition list failed, meet an unknown exception", e);
throw new ServiceException(Status.REQUEST_PARAMS_NOT_VALID_ERROR);
throw new ServiceException(Status.REQUEST_PARAMS_NOT_VALID_ERROR, taskDefinitionJson);
}
}

Expand Down