Skip to content

Conversation

@CauliflowerEater
Copy link

@CauliflowerEater CauliflowerEater commented Nov 10, 2025

Purpose of the pull request

To update UI label and variable name.

Brief change log

The “CreateDataSource” page's “publicKey” label has been updated to “privateKey”, the variable names throughout the entire call chain have been updated accordingly, and an upgrade script has been added to update historical data.

close #17573

Verify this pull request

This pull request is already covered by existing tests, such as
SSHDataSourceProcessorTest.java
UpgradeWithMysqlIT.java

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 10, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@github-actions github-actions bot added UI ui and front end related backend test labels Nov 10, 2025
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly first time contributor First-time contributor labels Nov 11, 2025
@SbloodyS SbloodyS added this to the 3.3.3 milestone Nov 11, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor improvement make more easy to user or prompt friendly test UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] [UI] When using DolphinScheduler 3.3, the wizard for configuring an SSH data source is misleading.

2 participants