[Improvement-18151] Simplify the code with lombok annotations#18174
Open
njnu-seafish wants to merge 4 commits intoapache:devfrom
Open
[Improvement-18151] Simplify the code with lombok annotations#18174njnu-seafish wants to merge 4 commits intoapache:devfrom
njnu-seafish wants to merge 4 commits intoapache:devfrom
Conversation
njnu-seafish
requested review from
Gallardot,
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
ruanwenjun
reviewed
Apr 17, 2026
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
Please do not modify non-POJO objects
|
|
||
| @ToString | ||
| @Slf4j | ||
| @Data |
Member
There was a problem hiding this comment.
Not all field should exposed to out layer, e.g latch, don't change the code you are not clear.
Comment on lines
-206
to
-211
| public void setDepList(List<Long> depList) { | ||
| if (depList != null) { | ||
| this.depList = depList; | ||
| this.preTasks = JSONUtils.toJsonString(depList); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The project compiles successfully, and this method is unused.
Comment on lines
+28
to
+29
| @Data | ||
| @Accessors(chain = true) |
Member
There was a problem hiding this comment.
Suggested change
| @Data | |
| @Accessors(chain = true) | |
| @Accessors(chain = true) |
Why add this?
Contributor
Author
There was a problem hiding this comment.
Why add this?
Here is the code before refactoring：
public ParamsProps setPlaceholder(String placeholder) {
this.placeholder = placeholder;
return this;
}
Yes, this is not used.
| @Accessors(chain = true) | ||
| public class ParamsProps { | ||
|
|
||
| @JsonProperty("placeholder") |
Contributor
Author
There was a problem hiding this comment.
Why add this?
Here is the code before refactoring：
public ParamsProps setPlaceholder(String placeholder) {
this.placeholder = placeholder;
return this;
}
Yes, this is not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES, First, use AI to identify redundant code, then manually verify and simplify it.
Purpose of the pull request
part of #18151
Brief change log
Simplify the code with lombok annotations
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md