Skip to content

[opt](varbinary) add conf control mapping iceberg uuid #59726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jan 12, 2026
Merged

[opt](varbinary) add conf control mapping iceberg uuid #59726

morningman merged 1 commit into from
Jan 12, 2026
+37 −6

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jan 9, 2026 •
edited
Loading

What problem does this PR solve?

Related PR: #59406

Problem Summary:
iceberg uuid type use the conf of enable.varbinary.mapping to control mapping type, default is mapping to string type.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jan 9, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 9, 2026

TPC-H: Total hot run time: 31972 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1f1dd7081003cc91dfa921b5ab19aef8be2a5c2b, data reload: false

------ Round 1 ----------------------------------
q1	17651	4202	4069	4069
q2	2067	353	238	238
q3	10130	1300	730	730
q4	10214	842	315	315
q5	7534	2076	1824	1824
q6	187	169	135	135
q7	940	801	643	643
q8	9272	1386	1124	1124
q9	4819	4567	4566	4566
q10	6778	1826	1429	1429
q11	541	286	281	281
q12	692	744	585	585
q13	17777	3847	3032	3032
q14	291	293	280	280
q15	575	520	505	505
q16	671	678	644	644
q17	670	765	533	533
q18	6604	6535	6869	6535
q19	1156	1056	674	674
q20	429	406	268	268
q21	3347	2621	2525	2525
q22	1102	1061	1037	1037
Total cold run time: 103447 ms
Total hot run time: 31972 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4348	4350	4171	4171
q2	343	414	333	333
q3	2260	2807	2438	2438
q4	1437	1874	1510	1510
q5	4435	4328	4387	4328
q6	210	171	127	127
q7	2007	1899	1829	1829
q8	2557	2518	2486	2486
q9	7222	7108	7153	7108
q10	2436	2883	2438	2438
q11	575	478	468	468
q12	728	746	610	610
q13	3636	4028	3251	3251
q14	269	282	266	266
q15	537	485	483	483
q16	668	645	605	605
q17	1108	1235	1274	1235
q18	7588	7452	7168	7168
q19	819	781	777	777
q20	1891	1951	1804	1804
q21	4461	4291	4195	4195
q22	1125	1023	963	963
Total cold run time: 50660 ms
Total hot run time: 48593 ms

@doris-robot
Copy link

doris-robot commented Jan 9, 2026

TPC-DS: Total hot run time: 173082 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1f1dd7081003cc91dfa921b5ab19aef8be2a5c2b, data reload: false

query5	4388	585	449	449
query6	348	246	236	236
query7	4237	474	284	284
query8	344	252	244	244
query9	8762	2646	2628	2628
query10	491	388	355	355
query11	15277	14976	14946	14946
query12	186	116	114	114
query13	1261	496	385	385
query14	6037	3036	2824	2824
query14_1	2757	2711	2734	2711
query15	209	195	179	179
query16	996	481	460	460
query17	1120	686	579	579
query18	2435	450	357	357
query19	236	233	206	206
query20	126	119	116	116
query21	219	139	126	126
query22	3998	4026	4035	4026
query23	16108	15686	15304	15304
query23_1	15595	15406	15643	15406
query24	7379	1528	1191	1191
query24_1	1223	1193	1216	1193
query25	561	487	427	427
query26	1250	271	155	155
query27	2769	448	291	291
query28	4539	2169	2154	2154
query29	835	556	472	472
query30	314	249	211	211
query31	811	641	559	559
query32	81	78	82	78
query33	556	351	339	339
query34	919	873	511	511
query35	722	752	671	671
query36	872	908	821	821
query37	129	88	77	77
query38	2721	2679	2669	2669
query39	785	735	739	735
query39_1	728	725	732	725
query40	219	134	115	115
query41	64	65	62	62
query42	106	103	105	103
query43	440	454	407	407
query44	1308	721	729	721
query45	186	186	177	177
query46	844	958	590	590
query47	1437	1467	1321	1321
query48	299	322	236	236
query49	598	424	326	326
query50	632	271	197	197
query51	3727	3778	3782	3778
query52	105	109	99	99
query53	291	328	273	273
query54	280	253	239	239
query55	77	77	107	77
query56	282	292	279	279
query57	1069	1008	922	922
query58	273	262	256	256
query59	2133	2112	2177	2112
query60	316	314	294	294
query61	159	158	162	158
query62	386	352	346	346
query63	302	267	277	267
query64	5113	1288	980	980
query65	3802	3725	3750	3725
query66	1437	408	313	313
query67	14950	15320	14737	14737
query68	6734	1014	693	693
query69	490	347	315	315
query70	1058	871	935	871
query71	388	301	282	282
query72	6089	3406	3485	3406
query73	767	720	298	298
query74	8767	8787	8648	8648
query75	2839	2840	2456	2456
query76	3767	1071	643	643
query77	523	383	315	315
query78	9684	9841	9190	9190
query79	1226	900	598	598
query80	622	574	504	504
query81	527	263	230	230
query82	211	145	107	107
query83	263	253	238	238
query84	262	121	104	104
query85	914	511	462	462
query86	408	324	326	324
query87	2876	2884	2752	2752
query88	3132	2227	2199	2199
query89	393	355	325	325
query90	2224	152	145	145
query91	177	176	141	141
query92	85	70	68	68
query93	1720	911	521	521
query94	580	281	290	281
query95	579	319	301	301
query96	573	458	207	207
query97	2298	2434	2285	2285
query98	240	203	193	193
query99	569	574	517	517
Total cold run time: 253602 ms
Total hot run time: 173082 ms

@doris-robot
Copy link

doris-robot commented Jan 9, 2026

BE UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.02% (18974/35789)
Line Coverage 39.07% (175767/449880)
Region Coverage 33.63% (136046/404535)
Branch Coverage 34.67% (58827/169686)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 9, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.03% (23098/34983)
Line Coverage 52.95% (237552/448644)
Region Coverage 48.47% (198055/408650)
Branch Coverage 49.33% (83974/170235)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 9, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.01% (23092/34983)
Line Coverage 52.92% (237419/448644)
Region Coverage 48.41% (197821/408650)
Branch Coverage 49.30% (83923/170235)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 10, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 66.01% (23092/34983)
Line Coverage 52.92% (237419/448644)
Region Coverage 48.41% (197821/408650)
Branch Coverage 49.30% (83923/170235)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

PR approved by anyone and no changes requested.

@morningman morningman merged commit 6210dec into apache:master Jan 12, 2026
31 of 33 checks passed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Jan 12, 2026
@zhangstar333
[opt](varbinary) add conf control mapping iceberg uuid (apache#59726)
8d63635 
Related PR: apache#59406

Problem Summary:
iceberg uuid type use the conf of enable.varbinary.mapping to control
mapping type, default is mapping to string type.
@morningman morningman mentioned this pull request Jan 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.0.x-conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhangstar333 @Thearas @doris-robot @hello-stephen @morningman @CalvinKirs @hubgeter