-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](metadata) optimize lock in recycle bin #59730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morrySnow
wants to merge
1
commit into
apache:master
Choose a base branch
from
morrySnow:opt_recycle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+544
−441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bd8ae47 to
bbe352d
Compare
bbe352d to
d279a31
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32036 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-DS: Total hot run time: 173238 ms |
ClickBench: Total hot run time: 26.75 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
This pull request refactors the
CatalogRecycleBinclass to improve thread safety and concurrency. The main changes involve replacing synchronized methods and non-thread-safe maps with concurrent data structures and explicit locking, ensuring safer access and modification in multi-threaded scenarios.Thread safety improvements:
HashMapfields (idToDatabase,idToTable,idToPartition,idToRecycleTime) with thread-safeConcurrentMapvariants to allow concurrent access.ReadWriteLock(lock) to manage concurrent read/write access, and wrapped critical sections of code that modify shared state with appropriate lock acquisition and release. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Code modernization and cleanup:
synchronizedkeyword from method signatures, relying instead on the new explicit locking mechanism for thread safety. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]allTabletsInRecycledStatuswith@VisibleForTestingand removed its synchronization for better testability and clarity.These changes make the recycle bin operations safer and more robust in concurrent environments, which is crucial for a multi-threaded system like Doris.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)