[fix](posexplode) fix return type check failure #59734
Open
+223
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 32188 ms |
Contributor
Author
|
run beut |
TPC-DS: Total hot run time: 173537 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
mrhhsg
reviewed
Jan 12, 2026
| fieldTypes[1] = | ||
| check_and_get_data_type<DataTypeArray>(arguments[0].get())->get_nested_type(); | ||
| for (int i = 0; i < arguments.size(); i++) { | ||
| DCHECK(arguments[0]->get_primitive_type() == TYPE_ARRAY) |
Member
There was a problem hiding this comment.
Move it to out of for loop,
Or maybe here should check arguments[i]?
And better use DCHECK_EQ instead of DCHECK
Comment on lines
127
to
131
| if (nestedType->is_nullable()) { | ||
| fieldTypes[i + 1] = nestedType; | ||
| } else { | ||
| fieldTypes[i + 1] = make_nullable(nestedType); | ||
| } |
Member
There was a problem hiding this comment.
fieldTypes[i + 1] = make_nullable(nestedType); is sufficient.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32124 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-DS: Total hot run time: 172686 ms |
ClickBench: Total hot run time: 26.68 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jan 16, 2026
Contributor
|
skip check_coverage |
zclllyybb
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix error of posexplode
function return type check failedRelated PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)