(fix)[variant] enhance VARIANT bloom filter & inverted index validation #59921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bcolumns in FE validation
…IANT subcolumns in FE validation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31954 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32435 ms |
TPC-DS: Total hot run time: 173807 ms |
ClickBench: Total hot run time: 26.78 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run cloud_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31523 ms |
TPC-DS: Total hot run time: 174184 ms |
ClickBench: Total hot run time: 26.95 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32499 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
csun5285
reviewed
Jan 20, 2026
| + fieldPattern + " is not supported for inverted index" | ||
| + " of column: " + column.getName()); | ||
| } | ||
| checkVariantFieldPatternInvertedIndex(column.getName(), fieldPattern, |
Contributor
There was a problem hiding this comment.
这里为啥不直接调用 InvertedIndexUtil.checkInvertedIndexParser
Contributor
Author
There was a problem hiding this comment.
已内联并删除该函数，保持逻辑不变
be/src/vec/common/schema_util.cpp
Outdated
| // above types are not supported in bf | ||
| if (is_bf_supported_by_fe_for_variant_subcolumn(target.type())) { | ||
| target.set_is_bf_column(source.is_bf_column()); | ||
| } else if (source.is_bf_column()) { |
Contributor
There was a problem hiding this comment.
这个日志不用打，或者改成debug，info 太频繁了
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31460 ms |
TPC-DS: Total hot run time: 172708 ms |
ClickBench: Total hot run time: 26.84 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…on (#59921) 1. keep variant subcolumn BF support aligned with FE DDL checks (BE) 2. reject analyzed inverted index on non-text VARIANT subcolumns (FE) 3. reject dict-compressed inverted index on non-text VARIANT subcolumns (FE)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)