fix: resolve resource leaks using try-with-resources #15874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15874 +/- ##
============================================
- Coverage 60.79% 60.76% -0.04%
- Complexity 11710 11725 +15
============================================
Files 1938 1938
Lines 88692 88683 -9
Branches 13387 13387
============================================
- Hits 53923 53886 -37
- Misses 29243 29261 +18
- Partials 5526 5536 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RainYuY
requested changes
Dec 16, 2025
Update Bzip2.compress() and Bytes.zip() to follow PMC requirements
…o fix-resource-leaks
RainYuY
approved these changes
Dec 16, 2025
zrlw
reviewed
Dec 18, 2025
| return new byte[0]; | ||
| } | ||
|
|
||
| ByteArrayOutputStream out = new ByteArrayOutputStream(); |
Contributor
There was a problem hiding this comment.
out should be included in try-with-resources block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
fix: resolve resource leaks using try-with-resources #15742