[Bug][Spring Boot] Fix AwaitingNonWebApplicationListener await() with parent context #15890
+52
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parent context - Handle parent contexts in await() properly - Unit test added to verify await() works with bootstrap parent context - Update Maven Surefire plugin configuration
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15890 +/- ##
============================================
- Coverage 60.75% 60.74% -0.01%
- Complexity 11703 11705 +2
============================================
Files 1938 1938
Lines 88694 88697 +3
Branches 13387 13388 +1
============================================
- Hits 53886 53879 -7
- Misses 29275 29287 +12
+ Partials 5533 5531 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
’ve pushed an update to address the failing test. The test has been simplified and corrected to properly validate AwaitingNonWebApplicationListener behavior with a parent context. All tests pass locally now. Please let me know if any further adjustments are needed. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
AwaitingNonWebApplicationListener.java
Updated await() logic to correctly handle parent contexts.
Ensures that await() completes even if the application context is not a root context.
AwaitingNonWebApplicationListenerTest.java
Rewrote the test to simulate a parent-child application context scenario.
Added an assertion to verify that await() completes successfully with a parent context.
pom.xml (dubbo-spring-boot)
Updated Maven Surefire plugin configuration to ensure JUnit Jupiter tests are executed properly.
Why this is important:
Fixes a blocking issue in non-web Spring Boot applications using Dubbo with a bootstrap parent context.
Improves test coverage to catch similar issues in the future.
Ensures consistent behavior of Dubbo application lifecycle handling.
Testing done:
Verified that AwaitingNonWebApplicationListenerTest passes locally with the updated logic.
Build succeeds with all existing tests.
Fixes #13722
please review this pr when you get time respected sir @RainYuY @AlbumenJ