Skip to content

Conversation

@qxggg
Copy link
Contributor

@qxggg qxggg commented Dec 24, 2025

What is the purpose of the change?

see #15892

Fix ByteBuf leak in HttpOutputMessage by closing it on write failure. Maintains proper CompletableFuture completion and avoids Netty leak warnings.

@qxggg qxggg changed the title fix #15892 fix #15892 [Bug] LEAK: ByteBuf.release() was not called before it's garbage-collected Dec 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.74%. Comparing base (a3a35b5) to head (dbc2f39).

Files with missing lines Patch % Lines
...o/remoting/http12/netty4/h1/NettyHttp1Channel.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15917   +/-   ##
=========================================
  Coverage     60.74%   60.74%           
+ Complexity    11702    11701    -1     
=========================================
  Files          1938     1938           
  Lines         88694    88698    +4     
  Branches      13387    13387           
=========================================
+ Hits          53879    53883    +4     
+ Misses        29291    29285    -6     
- Partials       5524     5530    +6     
Flag Coverage Δ
integration-tests-java21 32.44% <0.00%> (+0.06%) ⬆️
integration-tests-java8 32.44% <0.00%> (-0.09%) ⬇️
samples-tests-java21 32.01% <0.00%> (-0.01%) ⬇️
samples-tests-java8 29.69% <0.00%> (-0.01%) ⬇️
unit-tests-java11 59.04% <0.00%> (-0.01%) ⬇️
unit-tests-java17 58.53% <0.00%> (-0.01%) ⬇️
unit-tests-java21 58.51% <0.00%> (-0.01%) ⬇️
unit-tests-java25 58.48% <0.00%> (+<0.01%) ⬆️
unit-tests-java8 59.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants