Skip to content

Conversation

@somiljain2006
Copy link

What is the purpose of the change?

This change appends the registry ID to the reference cache key, preventing cache collisions between references with the same interface, group, and version but different registry configurations, and ensuring requests are routed to the intended registry.

Fixes #15761

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify your logic correction. If the new feature or significant change is committed, please remember to adda sample in the dubbo samples project.
  • Make sure GitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.75%. Comparing base (a3a35b5) to head (ce9c702).

Files with missing lines Patch % Lines
...pache/dubbo/config/utils/SimpleReferenceCache.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                3.3   #15918   +/-   ##
=========================================
  Coverage     60.74%   60.75%           
  Complexity    11702    11702           
=========================================
  Files          1938     1938           
  Lines         88694    88699    +5     
  Branches      13387    13390    +3     
=========================================
+ Hits          53879    53890   +11     
+ Misses        29291    29281   -10     
- Partials       5524     5528    +4     
Flag Coverage Δ
integration-tests-java21 32.41% <50.00%> (+0.04%) ⬆️
integration-tests-java8 32.45% <50.00%> (-0.08%) ⬇️
samples-tests-java21 32.06% <75.00%> (+0.04%) ⬆️
samples-tests-java8 29.73% <50.00%> (+0.03%) ⬆️
unit-tests-java11 59.05% <75.00%> (+<0.01%) ⬆️
unit-tests-java17 58.53% <75.00%> (+<0.01%) ⬆️
unit-tests-java21 58.52% <75.00%> (+<0.01%) ⬆️
unit-tests-java25 58.48% <75.00%> (+0.01%) ⬆️
unit-tests-java8 59.03% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] When subscribing to the same service from multiple registry centers in Dubbo 3.3.4, subscription relationships are not handled correctly.

2 participants