FINERACT-2312: full term calculation

[budaidev]

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[adamsaghy]

> Task :fineract-progressive-loan-embeddable-schedule-generator:test

org.apache.fineract.portfolio.loanaccount.loanschedule.domain.EmbeddableProgressiveLoanScheduleGeneratorTest

  Test testGenerate() PASSED

SUCCESS: Executed 1 tests in 2.6s

gradle/actions: Writing build results to /home/runner/work/_temp/.gradle-actions/build-results/__run_2-1765970062079.json

[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14.3/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 29s
49 actionable tasks: 1 executed, 48 up-to-date
Error: Exception in thread "main" java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
	at org.apache.fineract.portfolio.loanaccount.loanschedule.domain.ProgressiveLoanScheduleGenerator.<clinit>(ProgressiveLoanScheduleGenerator.java:62)
	at org.apache.fineract.portfolio.loanaccount.loanschedule.domain.EmbeddableProgressiveLoanScheduleGenerator.<init>(EmbeddableProgressiveLoanScheduleGenerator.java:41)
	at Main.main(Main.java:43)
Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 3 more
Error: Process completed with exit code 1.

[adamsaghy]

    (see https://errorprone.info/bugpattern/NonApiType)
/home/runner/work/fineract/fineract/fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java:1672: error: [UnusedMethod] Method 'calculateFnResultFromDate' is never used.
    private BigDecimal calculateFnResultFromDate(final List<RepaymentPeriod> periods, final LocalDate fromDate, final MathContext mc) {
                       ^
    (see https://errorprone.info/bugpattern/UnusedMethod)
  Did you mean to remove this line?

[Aman-Mittal]

getRateFactorPlus1FromDate
has implementation .reduce(BigDecimal.ONE, BigDecimal::add);

1 + rate1 + rate2 + rate3 ...

But the Javadoc says:

sum of (Rate Factor + 1) from interest periods
similar to.
(rate1 + 1) + (rate2 + 1) + ...

Needs some more clarification in this javadoc, it is ambiguous

[Aman-Mittal]

Are we sure that interestPeriods never be null?