Skip to content

Conversation

@adamsaghy
Copy link
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/upgrade-to-hardened-image branch from 8fa82c2 to a6a7711 Compare December 18, 2025 16:48
@adamsaghy adamsaghy force-pushed the FINERACT-2421/upgrade-to-hardened-image branch from a6a7711 to 754e09a Compare December 18, 2025 17:09
@Aman-Mittal
Copy link
Contributor

I am asking this while it is still in Draft, If this gets merged, do i have to maintain my own secrets in my fork repository, to run github workflow integration test. if i raise new PR.

What i actually do, before raising PR, i run the same e2e workflow same as this repository. To make sure PR runs work successfully first time.

@adamsaghy
Copy link
Contributor Author

I am asking this while it is still in Draft, If this gets merged, do i have to maintain my own secrets in my fork repository, to run github workflow integration test. if i raise new PR.

What i actually do, before raising PR, i run the same e2e workflow same as this repository. To make sure PR runs work successfully first time.

I am just testing the ground, there will be no need for any secret management from contributors side... this will not be merged for a while till all angles are covered and community decision was made: hence draft status

@IOhacker
Copy link
Contributor

@adamsaghy seems that help from Apache Infra is required for setting the credentials for the DHI repository. I think that the README must include some instruction about the DHI credentials required for building/running the dockerized version. Everything else looks good for me.

@adamsaghy
Copy link
Contributor Author

@adamsaghy seems that help from Apache Infra is required for setting the credentials for the DHI repository. I think that the README must include some instruction about the DHI credentials required for building/running the dockerized version. Everything else looks good for me.

Probably we need dual building. One for PRs and one if something got merged to develop. While the 1st can work on "public" images, the latter can be on hardened images... it's not perfect, but it could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants