[spark] Add sparksql alter table partial support for set/remove table properties #2437
+89
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This was referenced Jan 22, 2026
Contributor
Author
|
flink ut failed with |
YannByron
reviewed
Jan 23, 2026
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/SparkCatalog.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 23, 2026
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/SparkCatalog.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 23, 2026
| checkAnswer(sql("SHOW DATABASES"), Row(DEFAULT_DATABASE) :: Nil) | ||
| } | ||
|
|
||
| test("Catalog: set/remove table properties") { |
Contributor
There was a problem hiding this comment.
Maybe it'll be nice to have a separate SparkTableChangeTest, which includes all Alter Table tests.
Contributor
Author
There was a problem hiding this comment.
above comments suggests add all DDL tests into one suite.
YannByron
reviewed
Jan 23, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Outdated
Show resolved
Hide resolved
YannByron
reviewed
Jan 23, 2026
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@Yohahaha left some comments here, and I suggest to simplify this title to |
wuchong
approved these changes
Jan 24, 2026
wuchong
reviewed
Jan 24, 2026
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Hi @Yohahaha, I agree with @YannByron's comments. Could you please update the pull request to address them?
wuchong
approved these changes
Jan 26, 2026
Comment on lines
233
to
236
| intercept[ExecutionException] { | ||
| sql( | ||
| s"ALTER TABLE t SET TBLPROPERTIES('${ConfigOptions.TABLE_DATALAKE_FORMAT.key()}' = 'paimon')") | ||
| }.getCause.shouldBe(a[InvalidAlterTableException]) |
Member
There was a problem hiding this comment.
Actually, this can be supported. But you need to enable datalake feature on the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Brief change log
As title.
Tests
Catalog: set/remove table propertiesinorg.apache.fluss.spark.SparkCatalogTestAPI and Format
Documentation