-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[improve] optimize the function of creating monitoring using AI #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LiuTianyou
wants to merge
18
commits into
apache:master
Choose a base branch
from
LiuTianyou:improve-ai
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b434649
[improve] use security form collect password
LiuTianyou d43dd22
[improve] use security form collect password or other sensitive infor…
LiuTianyou 0c673d4
[improve] use security form collect password or other sensitive infor…
LiuTianyou 2f68a6e
Merge branch 'master' into improve-ai
LiuTianyou 3483cae
Merge remote-tracking branch 'origin/improve-ai' into improve-ai
LiuTianyou fc12017
[improve] use security form collect password or other sensitive infor…
LiuTianyou c2c670d
[improve] use security form collect password or other sensitive infor…
LiuTianyou decfc7d
[improve] use security form collect password or other sensitive infor…
LiuTianyou e946fa4
[improve] use security form collect password or other sensitive infor…
LiuTianyou 153c24a
Merge branch 'master' into improve-ai
lynx009 f75283d
Merge branch 'master' into improve-ai
Aias00 3855bb0
Merge branch 'master' into improve-ai
yuluo-yx c932a64
Merge branch 'master' into improve-ai
Duansg ecbbd22
Merge branch 'master' into improve-ai
Duansg e90766c
Merge branch 'master' into improve-ai
Duansg 08f03cf
Update web-app/src/app/shared/components/ai-chat/chat.component.ts
Aias00 21646ec
Update web-app/src/app/shared/components/ai-chat/chat.component.ts
Aias00 0a11d49
Merge branch 'master' into improve-ai
Aias00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
hertzbeat-ai/src/main/java/org/apache/hertzbeat/ai/pojo/dto/SecurityData.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hertzbeat.ai.pojo.dto; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import lombok.Data; | ||
|
|
||
| /** | ||
| * security data | ||
| */ | ||
| @Data | ||
| public class SecurityData { | ||
|
|
||
| @NotNull | ||
| @Schema(description = "Conversation ID", example = "123") | ||
| private Long conversationId; | ||
|
|
||
| @NotNull | ||
| @Schema(description = "security data", example = "{\"password\":\"xxxxx\"}") | ||
| private String securityData; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing input validation. The SecurityData object should be validated for null conversationId and empty/null securityData before processing. Add validation annotations like @NotNull on the conversationId field and @notblank on securityData field in the SecurityData class, or add explicit validation in the controller method.