Skip to content

fix: validate deletion vectors against Puffin metadata - #914

Draft
wirybeaver wants to merge 2 commits into
apache:mainfrom
wirybeaver:fix/dv-puffin-metadata-validation
Draft

fix: validate deletion vectors against Puffin metadata#914
wirybeaver wants to merge 2 commits into
apache:mainfrom
wirybeaver:fix/dv-puffin-metadata-validation

Conversation

@wirybeaver

Copy link
Copy Markdown

Summary

  • validate deletion vector manifest ranges against the matching Puffin footer blob
  • validate deletion-vector-v1 metadata, referenced data file, and cardinality before reading
  • reject trailing bytes after the serialized Roaring bitmaps
  • run the Java and Go interoperability fixtures through the standard DV reader

Stacked on #913. Until #913 merges, this PR contains both commits; review commit 0ff15f6 for this change.

Related to #637.

Testing

  • pre-commit hooks: passed
  • puffin_test: 34/34 passed
  • util_test: 371/371 passed
  • GCC 14 container build: passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant