Skip to content

fix: enforce deletion vector scan applicability - #915

Draft
wirybeaver wants to merge 2 commits into
apache:mainfrom
wirybeaver:fix/dv-partition-spec-matching
Draft

fix: enforce deletion vector scan applicability#915
wirybeaver wants to merge 2 commits into
apache:mainfrom
wirybeaver:fix/dv-partition-spec-matching

Conversation

@wirybeaver

Copy link
Copy Markdown

Summary

  • require deletion vectors to match the data file partition spec ID and partition tuple
  • compare partition tuples with typed StructLikeEqual, including null values
  • treat older same-path deletion vectors as inapplicable and fall back to position deletes
  • confirm applicable deletion vectors supersede file-scoped position deletes

Stacked on #913. Until #913 merges, this PR contains both commits; review commit dc84d6e for this change.

Related to #637.

Testing

  • pre-commit hooks: passed
  • GCC 14 DeleteFileIndexVersions/DeleteFileIndexTest.*: 50 passed, 8 expected skips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant