Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Nov 15, 2025

What changes are proposed in this pull request?

Adds Scala binary version suffix to the published artifactId and fixes shaded jar classifier attachment to include OS, architecture, Spark version.

Example usage of the new shaded classifiers.
Maven (choose one classifier matching your platform / build variant):

<dependency>
  <groupId>org.apache.gluten</groupId>
  <artifactId>gluten-package_2.12</artifactId>
  <version>1.6.0-SNAPSHOT</version>
  <classifier>velox-spark3.5-darwin_aarch64</classifier>
</dependency>

SBT:

libraryDependencies += "org.apache.gluten" % "gluten-package_2.12" % "1.6.0-SNAPSHOT" classifier "velox-spark3.5-darwin_aarch64"

Gradle (Groovy DSL):

dependencies {
  implementation("org.apache.gluten:gluten-package_2.12:1.6.0-SNAPSHOT:velox-spark3.5-darwin_aarch64")
}

How was this patch tested?

Manual test. Examples now generated:

-rw-r--r--@ 1 wangyum  staff     10249 Nov 15 23:55 gluten-package_2.12-1.6.0-SNAPSHOT-3.5.jar
-rw-r--r--@ 1 wangyum  staff  10116530 Nov 15 23:43 gluten-package_2.12-1.6.0-SNAPSHOT-darwin_aarch64-spark3.5-sources.jar
-rw-r--r--@ 1 wangyum  staff  36496314 Nov 15 23:43 gluten-package_2.12-1.6.0-SNAPSHOT-darwin_aarch64-spark3.5.jar
-rw-r--r--@ 1 wangyum  staff  10116530 Nov 15 23:55 gluten-package_2.12-1.6.0-SNAPSHOT-velox-spark3.5-darwin_aarch64-sources.jar
-rw-r--r--@ 1 wangyum  staff  36496315 Nov 15 23:55 gluten-package_2.12-1.6.0-SNAPSHOT-velox-spark3.5-darwin_aarch64.jar
-rw-r--r--@ 1 wangyum  staff     10249 Nov 15 23:54 gluten-package_2.12-1.6.0-SNAPSHOT.jar
-rw-r--r--@ 1 wangyum  staff  36496315 Nov 15 23:55 gluten-velox-bundle-spark3.5_2.12-darwin_aarch64-1.6.0-SNAPSHOT.jar
drwxr-xr-x@ 3 wangyum  staff        96 Nov 15 23:54 maven-archiver
drwxr-xr-x@ 3 wangyum  staff        96 Nov 15 23:54 maven-shared-archive-resources
drwxr-xr-x@ 4 wangyum  staff       128 Nov 15 23:54 scala-2.12

Related issue: #11096

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

sed -e "$1" "$2" > "$2.tmp" && mv "$2.tmp" "$2"
}

sed_i 's/\(artifactId.*\)_'$FROM_VERSION'/\1_'$TO_VERSION'/g' package/pom.xml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@zhztheplayer
Copy link
Member

Thanks. Does this work with Spark --packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants