-
Notifications
You must be signed in to change notification settings - Fork 549
[GLUTEN-11096] Add scala.binary.version to gluten-package #11097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Run Gluten Clickhouse CI on x86 |
| sed -e "$1" "$2" > "$2.tmp" && mv "$2.tmp" "$2" | ||
| } | ||
|
|
||
| sed_i 's/\(artifactId.*\)_'$FROM_VERSION'/\1_'$TO_VERSION'/g' package/pom.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file copy from https://github.com/apache/spark/blob/master/dev/change-scala-version.sh
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
903bdfa to
8d8ec96
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
7166584 to
b44fd33
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Thanks. Does this work with Spark |
What changes are proposed in this pull request?
Adds Scala binary version suffix to the published artifactId and fixes shaded jar classifier attachment to include OS, architecture, Spark version.
Example usage of the new shaded classifiers.
Maven (choose one classifier matching your platform / build variant):
SBT:
Gradle (Groovy DSL):
dependencies { implementation("org.apache.gluten:gluten-package_2.12:1.6.0-SNAPSHOT:velox-spark3.5-darwin_aarch64") }How was this patch tested?
Manual test. Examples now generated:
Related issue: #11096