Skip to content

Conversation

@jinchengchenghh
Copy link
Contributor

@jinchengchenghh jinchengchenghh commented Nov 18, 2025

  1. Adapt to iceberg new test frame work, remove the constructor.
  2. Add new profile iceberg-test, if activated, compile and execute the test in folder src-iceberg-spark34
  3. Upgrade hadoop version to hadoop3.4.1 when activate profile iceberg-test
  4. Fallback v3 delete read
  5. Fallback mergeSchema
  6. Upgrade ClickHouse flink connector to 1.19
  7. Cannot upgrade fasterxml jackson version to 2.19.2 because since 2.16, SPARK-33286: from_json - combined error messages will fail by StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION
  8. jackson issue is because RESTObjectMapper exists in iceberg-spark-runtime jar, ObjectMapper is a shaded class in this jar, so the function return unshaded class cannot find, the function is called by RegisterExtension RESTServerExtension which is in iceberg-open-api testFixtures jar, the unshaded ObjectMapper is in iceberg-open-api jar, so it will find unshaded ObjectMapper. the solution maybe compile iceberg-open-api jar with shaded class, then the external project can use it, Or remove the shaded iceberg runtime, but this may cause user experience runtime issue if Gluten uses iceberg returned non-shaded class, so this is not suggested, may try include iceberg non-runtime jar before runtime jar in the test scope. We don't need to test RestCatalog, so I remove it now.
    java.lang.NoSuchMethodError: 'com.fasterxml.jackson.databind.ObjectMapper org.apache.iceberg.rest.RESTObjectMapper.mapper()&apos

Related issue: #11108

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Nov 18, 2025
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions github-actions bot added the INFRA label Nov 18, 2025
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@PHILO-HE PHILO-HE changed the title [GLUTEN-11108][VL] Upgrade iceberg version to 1.10.0 for spark3.4 and 3.5 [GLUTEN-11108][VL] Upgrade iceberg version to 1.10.0 for spark 3.4 and 3.5 Nov 19, 2025
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@jinchengchenghh
Copy link
Contributor Author

Looks like org.apache.iceberg:iceberg-flink-runtime-1.18:jar:1.10.0, is not available, can we update it to https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-flink-runtime-1.19 ? @baibaichen

9:15:42  [INFO] Gluten Iceberg ..................................... SUCCESS [ 12.486 s]
19:15:42  [INFO] Gluten DeltaLake ................................... SUCCESS [  7.995 s]
19:15:42  [INFO] Gluten Package ..................................... SUCCESS [  5.501 s]
19:15:42  [INFO] Gluten Ras Planner ................................. SUCCESS [  1.035 s]
19:15:42  [INFO] Gluten Kafka ....................................... SUCCESS [  8.023 s]
19:15:42  [INFO] Gluten Backends ClickHouse ......................... FAILURE [  5.869 s]
19:15:42  [INFO] Gluten Unit Test Parent ............................ SKIPPED
19:15:42  [INFO] Gluten Unit Test Common ............................ SKIPPED
19:15:42  [INFO] Gluten Unit Test ................................... SKIPPED
19:15:42  [INFO] Gluten Unit Test Spark35 ........................... SKIPPED
19:15:42  [INFO] ------------------------------------------------------------------------
19:15:42  [INFO] BUILD FAILURE
19:15:42  [INFO] ------------------------------------------------------------------------
19:15:42  [INFO] Total time:  04:08 min
19:15:42  [INFO] Finished at: 2025-11-20T19:15:41Z
19:15:42  [INFO] ------------------------------------------------------------------------
19:15:42  [ERROR] Failed to execute goal on project backends-clickhouse: Could not resolve dependencies for project org.apache.gluten:backends-clickhouse:jar:1.6.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.iceberg:iceberg-flink-runtime-1.18:jar:1.10.0, org.apache.iceberg:iceberg-flink-1.18:jar:tests:1.10.0, org.apache.iceberg:iceberg-flink-1.18:jar:1.10.0: org.apache.iceberg:iceberg-flink-runtime-1.18:jar:1.10.0 was not found in http://nexus.cicd:8081/repository/maven-public/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of ali-repo has elapsed or updates are forced -> [Help 1]
19:15:42  [ERROR] 
19:15:42  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
19:15:42  [ERROR] Re-run Maven using the -X switch to enable full debug logging.

@jinchengchenghh jinchengchenghh changed the title [GLUTEN-11108][VL] Upgrade iceberg version to 1.10.0 for spark 3.4 and 3.5 [GLUTEN-11108][CORE] Upgrade iceberg version to 1.10.0 for spark 3.4 and 3.5 Nov 21, 2025
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also enable iceberg-test for Spark-3.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all test exists in folder src-iceberg-spark34, we may need to do a refactor and add test for spark3.5 and 4.0, I will try to add them in #11146

@zhouyuan
Copy link
Contributor

Cc: @marin-ma

@jinchengchenghh jinchengchenghh merged commit 83fd760 into apache:main Nov 21, 2025
158 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants