Repository navigation
Conversation
…Lucene and Elastic with the query engine
| * {@code Export-Package} (see oak-lucene/pom.xml), so toggles here can be removed once retired | ||
| * without an OSGi baseline / API compatibility break. | ||
| */ | ||
| public final class LuceneFeatureToggles { |
Member
There was a problem hiding this comment.
Could we use a class that is shared (usable for both Elastic and Lucene)? Like FulltextIndexEditor
Member
|
Could you open a new PR against the OAK-12344 branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an ordered property, nodes without a useable value (absent, or not convertible to the declared type) were sorted differently by Lucene (as 0 / the epoch), Elastic (last in both directions) and the query engine (first ascending, last descending). Union queries with ORDER BY could therefore place such nodes in the middle of the results.
Both indexes now follow the query engine’s convention: such nodes sorts first in ascending and last in descending order.
missing: _firston ascending property sorts,missing: _laston descending property sorts